fix(perf): generate static edge redirects for Next.js redirects where possible #3040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=80&v=4){kind=small}
📊 Package size report 0.05%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
force-pushed
the
feat/static-redirects
branch
from
7119063 to
5c54c76
Compare
This change introduces the ability to generate static Netlify redirects for a subset of Next.js redirects defined in `next.config.js`. This offloads simple redirects to Netlify's edge, reducing function invocations and improving performance. The new `setRedirectsConfig` function handles simple redirects, including those with placeholders and splats, by converting them to the Netlify redirect format. Complex redirects that use `has`, `missing`, or regex-based sources will continue to be handled by the serverless function at runtime. Unit tests have been added to verify the redirect generation logic. An E2E test has also been added to ensure that simple redirects are handled by the edge, while complex redirects are correctly passed to the serverless function. The E2E test uses the `debug-x-nf-function-type` header to differentiate between edge-handled and function-handled responses. The E2E test has been refactored to have separate, descriptively named tests for each redirect case to improve readability and maintainability.
serhalp
force-pushed
the
feat/static-redirects
branch
from
5c54c76 to
4a38bc7
Compare
serhalp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates static Netlify redirects for a subset of Next.js redirects defined in
next.config.js—those that Netlify's redirects engine is able to support currently. This offloads simple redirects to Netlify's edge, reducing function invocations, which improves performance and reduces compute costs.The new
setRedirectsConfigfunction handles simple redirects, including those with placeholders and splats, by converting them to the Netlify redirect format.Complex redirects that use
has,missing, or regex-based sources will continue to be handled by the serverless function at runtime. In fact, to keep things simple, this PR does not introduce any changes to the existing runtime redirects logic at all.